[Multilingual] Simplify language imports #10026
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Language: PHP
driusan
added
Cleanup
driusan
force-pushed
the
SimplifyLanguageImports
branch
from
10839c9 to
de90550
Compare
github-actions
bot
added
Language: PHP
The importing of a named variable for every language at the top of multilingual files, just to pass it to addResourceBundle is getting a little unwieldy. Replace them with an inline require() at the addResourceBundle call site so that we don't need to pollute the import namespace for every language (and to make life easier if dialects are added such as en-CA and en-US).
driusan
force-pushed
the
SimplifyLanguageImports
branch
from
de90550 to
977ef8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importing of a named variable for every language at the top of multilingual files, just to pass it to addResourceBundle is getting a little unwieldy.
Replace them with an inline require() at the addResourceBundle call site so that we don't need to pollute the import namespace for every language (and to make life easier if dialects are added such as en-CA and en-US).
Testing instructions: Nothing should be affected in LORIS. In particular, translations should still be translated.