[Core] set intl.default_locale #10053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IntlDateFormatter in PHP uses the value of intl.default_locale, not \setlocale in order to decide on the formatting to use for dates when a null value/empty string is passed as the locale. This explicitly sets it so that dates in the en-CA locale are formatted as YYYY-mm-dd instead of YYYY/mm/dd.
|
For a bit of context/history I think this was detected and discussed a bit in #10024, ( then after mostly orally). This fix looks good to me. |
racostas
approved these changes
Oct 20, 2025
racostas
added
Multilingual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntlDateFormatter in PHP uses the value of intl.default_locale, not \setlocale in order to decide on the formatting to use for dates when a null value/empty string is passed as the locale.
This explicitly sets it so that dates in the en-CA locale are formatted as YYYY-mm-dd instead of YYYY/mm/dd.