Skip to content

Conversation

@kongtiaowang
Copy link
Contributor

test: run "php CouchDB_Import_Demographics.php" without issue

@kongtiaowang kongtiaowang added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Apr 15, 2025
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Apr 15, 2025
@skarya22
Copy link
Contributor

@skarya22 confirm that CandID only shows up and not candidate.ID in dqt

@skarya22 skarya22 self-requested a review May 13, 2025 15:14
@kongtiaowang kongtiaowang changed the base branch from main to 27.0-release May 13, 2025 17:23
$tablesToJoin .= "
LEFT JOIN (
SELECT c.CandID, Diagnosis
SELECT c.ID as CandidateID, c.CandID, Diagnosis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to select the CandidateID?

Copy link
Contributor Author

@kongtiaowang kongtiaowang May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the following query requires candidateID (line 307,311), candidateID is an alias.

@skarya22 skarya22 assigned kongtiaowang and unassigned skarya22 May 22, 2025
@skarya22 skarya22 added the State: Needs clarification PR or issue that needs to clarify its intent to proceed label May 22, 2025
@kongtiaowang kongtiaowang requested a review from skarya22 May 26, 2025 13:14
@kongtiaowang kongtiaowang removed the State: Needs clarification PR or issue that needs to clarify its intent to proceed label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: PHP PR or issue that update PHP code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants