Skip to content

[genomic_browser] Solve the issues #9773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented May 1, 2025

Brief summary of changes

  • Help was missing, added something basic so that there is at least something
  • Removed DoB from the data as it was visible when downloading the CSV.
  • Cleaned up the TestPlan document
  • Makes Upload Form button only appear when you have permission to Upload to genomic browser
  • Close FileUploadModal after successful upload
  • Fixes the File Upload to work properly

Testing instructions (if applicable)

  1. Check that helptext loads
  2. Download csv from tabs and confirm DoB is no longer present
  3. Try to upload a file in the Files tab and confirm it works
  4. Remove the genomic_browser_upload permission and confirm you do not see the Upload File button in the Files tab

Link(s) to related issue(s)

@skarya22 skarya22 added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label May 1, 2025
@skarya22 skarya22 added this to the 27.0.0 milestone May 1, 2025
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: genomic_browser PR or issue related to genomic_browser module labels May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: genomic_browser PR or issue related to genomic_browser module
Projects
None yet
2 participants