Skip to content

[user_accounts] Translate user_accounts module #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[user_accounts] Translate user_accounts module #9934

wants to merge 17 commits into from

Conversation

@SKADE2303
Copy link
Collaborator

@SKADE2303 SKADE2303 commented Jul 30, 2025

Brief summary of changes

This PR is responsible for translating the module user_accounts to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to User_Accounts tab to see translated web page.

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: conflict_resolver PR or issue related to conflict_resolver module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: examiner PR or issue related to examiner module Module: genomic_browser PR or issue related to genomic_browser module Module: imaging_browser PR or issue related to imaging_browser module Module: media PR or issue related to media module Module: server_processes_manager PR or issue related to the server_processes_manger Module: survey_accounts PR or issue related to the survey_accounts module Module: user_accounts PR or issue related to the user_accounts module Module: dicom_archive PR or issue related to dicom_archive module labels Jul 30, 2025
@SKADE2303 SKADE2303 removed Language: PHP PR or issue that update PHP code Module: statistics PR or issue related to statistics module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: conflict_resolver PR or issue related to conflict_resolver module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: examiner PR or issue related to examiner module labels Jul 30, 2025
@racostas racostas self-requested a review October 28, 2025 03:06
racostas

This comment was marked as resolved.

Sign in to view

@racostas

This comment was marked as resolved.

Sign in to view
racostas

This comment was marked as resolved.

Sign in to view

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 28, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateUserAccounts branch 2 times, most recently from a8525c9 to e9e2edb Compare October 28, 2025 21:22
@racostas racostas self-requested a review October 29, 2025 06:12
racostas
racostas requested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready. Two more minor changes. Thanks !

modules/user_accounts/jsx/userAccountsIndex.js
result = <td>{t('Yes', {ns: 'loris'})}</td>;
} else if (row['Pending Approval'] === 'N') {
} else if (row[pendingKey] === 'N') {
result = <td>{t('No', {ns: 'loris'})}</td>;
Copy link
Contributor

@racostas racostas Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SKADE2303, we need to do the same for the Active column. It's not getting translated so far.
image

locale/hi/LC_MESSAGES/loris.po Outdated
Comment on lines 237 to 241
msgid "Username"
msgstr "उपयोगकर्ता नाम"

msgid "User name"
msgstr "उपयोगकर्ता नाम"
Copy link
Contributor

@racostas racostas Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need both, let's just keep Username and change for this key wherever we have User name.
What do you think @driusan ?

Copy link
Contributor

@racostas racostas Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SKADE2303 I consulted @driusan in this one and he agreed it should be Username only. You have green light for making the respective changes. Thanks !!

@SKADE2303 SKADE2303 force-pushed the TranslateUserAccounts branch from ca999db to 618200c Compare October 29, 2025 15:23
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 31, 2025
racostas
racostas requested changes Nov 2, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This word is not properly been translated during my testing
image

Probably because of the Capitalized "A". Also please the "colon" should be no part of the translation.

Thanks.

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Nov 2, 2025
@racostas
Copy link
Contributor

racostas commented Nov 2, 2025

This word is not properly been translated during my testing image

Probably because of the Capitalized "A". Also please the "colon" should be no part of the translation.

Thanks.

In facts don't seems to be translated in the code:
image

@racostas
Copy link
Contributor

racostas commented Nov 2, 2025

More unstranslated
image

@racostas
Copy link
Contributor

racostas commented Nov 3, 2025

@SKADE2303, please address comments.

@christinerogers

@SKADE2303 SKADE2303 force-pushed the TranslateUserAccounts branch from bd1e0f5 to aa3ba31 Compare November 3, 2025 21:10
@SKADE2303 SKADE2303 removed the State: Needs work PR awaiting additional work by the author to proceed label Nov 4, 2025
@racostas racostas self-requested a review November 4, 2025 16:34
racostas
racostas approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@racostas
Copy link
Contributor

racostas commented Nov 4, 2025

I left you the final review @driusan . Thanks !

@racostas racostas requested review from driusan and racostas and removed request for racostas November 4, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racostas racostas racostas approved these changes

@driusan driusan Awaiting requested review from driusan

Assignees

@racostas racostas

@SKADE2303 SKADE2303

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: user_accounts PR or issue related to the user_accounts module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SKADE2303 @christinerogers @driusan @racostas @kongtiaowang