[conflict_resolver] Translate conflict resolver #9953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Language: PHP
SKADE2303
removed
Language: PHP
This translates the candidate list module as an example of how to do localization of a loris module that is written in React with class based components.
…dule is fully translated
… list module is fully translated" This reverts commit b467ce6.
…dule is fully translated
Also fix syntax of export to fix tests.
SKADE2303
force-pushed
the
TranslateConflictResolver
branch
from
c043761 to
6b4aeb8
Compare
github-actions
bot
added
Module: candidate_list
added 2 commits
September 1, 2025 08:30
SKADE2303
added
State: Needs work
racostas
reviewed
Sep 2, 2025
| npx i18next-conv -l hi -s modules/data_release/locale/hi/LC_MESSAGES/data_release.po -t modules/data_release/locale/hi/LC_MESSAGES/data_release.json | ||
| msgfmt -o modules/data_release/locale/ja/LC_MESSAGES/data_release.mo modules/data_release/locale/ja/LC_MESSAGES/data_release.po | ||
| npx i18next-conv -l ja -s modules/data_release/locale/ja/LC_MESSAGES/data_release.po -t modules/data_release/locale/ja/LC_MESSAGES/data_release.json | ||
| data_release: |
There was a problem hiding this comment.
This module translations were already merged, why we are deleting them in this PR ?
racostas
reviewed
Sep 2, 2025
| msgstr "ページあたりの最大行数:" | ||
|
|
||
| msgid "Download Table as CSV" | ||
| msgstr "表をCSVとしてダウンロード" |
There was a problem hiding this comment.
Why we are changing the JA translations in this PR ?
There was a problem hiding this comment.
I think this PR probably needs to be rebased?
racostas
reviewed
Sep 2, 2025
| msgid "Conflict ID" | ||
| msgstr "टकराव आईडी" | ||
|
|
||
| msgid "Cohort" |
There was a problem hiding this comment.
This one is already in the loris namespace, don't belong here, please see check for all the translations in this file since this one is just one example but there are many other in this same case. Thanks
racostas
requested changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module conflict_resolver to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)