Skip to content

[document_repository] Translate document repository #9954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[document_repository] Translate document repository #9954

wants to merge 3 commits into from

Conversation

SKADE2303
Copy link
Collaborator

This PR is responsible for translating the module document_repository to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to document_repository tab to see translated web page.

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: conflict_resolver PR or issue related to conflict_resolver module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: document_repository PR or issue related to documen_repository module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: examiner PR or issue related to examiner module Module: genomic_browser PR or issue related to genomic_browser module Module: imaging_browser PR or issue related to imaging_browser module Module: media PR or issue related to media module Module: server_processes_manager PR or issue related to the server_processes_manger Module: survey_accounts PR or issue related to the survey_accounts module Module: user_accounts PR or issue related to the user_accounts module Module: dicom_archive PR or issue related to dicom_archive module labels Aug 11, 2025
@SKADE2303 SKADE2303 removed Language: PHP PR or issue that update PHP code Module: statistics PR or issue related to statistics module Module: acknowledgements PR or issue related to acknowledgements module Module: battery_manager PR or issue related to battery_manager module Module: behavioural_qc PR or issue related behavioural_qc module Module: candidate_list PR or issue related to candidate_list module Module: conflict_resolver PR or issue related to conflict_resolver module Module: datadict PR or issue related to (old) datadict module Module: dictionary PR or issue related to (new) dictionary module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Aug 11, 2025
@SKADE2303 SKADE2303 added Event: GSOC PR or issue accepted for Google Summer of Code Multilingual Any tasks related to making LORIS multilingual and removed Module: imaging_browser PR or issue related to imaging_browser module Module: media PR or issue related to media module Module: server_processes_manager PR or issue related to the server_processes_manger Module: survey_accounts PR or issue related to the survey_accounts module Module: user_accounts PR or issue related to the user_accounts module Module: dicom_archive PR or issue related to dicom_archive module labels Aug 11, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateDocumentRepository branch from 1365ea0 to dc2ff91 Compare August 11, 2025 13:58
@racostas racostas self-requested a review August 12, 2025 14:47
driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/deleteCategoryForm.js
if (this.state.error) {
return <h3>An error occured while loading the page.</h3>;
return <h3>{t('An error occured while loading the page.',
{ns: 'document_repository'})}</h3>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in the loris namespace?

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/docIndex.js
if (this.state.error) {
return <h3>An error occured while loading the page.</h3>;
return <h3>{t('An error occured while loading the page.',
{ns: 'document_repository'})}</h3>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong namespace here too?

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/editForm.js
if (this.state.error) {
return <h3>An error occured while loading the page.</h3>;
return <h3>{t('An error occured while loading the page.',
{ns: 'document_repository'})}</h3>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris string

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/editForm.js
<SelectElement
name="forSite"
label="Site"
label={t('Site', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/editForm.js
<SelectElement
name="instrument"
label="Instrument"
label={t('Instrument', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it currently exists in the loris namespace but "Instrument" is a common loris term that should be in that namespace.

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/editForm.js
<TextboxElement
name="pscid"
label="PSCID"
label={t('PSCID', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/editForm.js
<TextboxElement
name="visitLabel"
label="Visit Label"
label={t('Visit Label', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/uploadForm.js
if (this.state.error) {
return <h3>An error occured while loading the page.</h3>;
return <h3>{t('An error occured while loading the page.',
{ns: 'document_repository'})}</h3>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/uploadForm.js
name="forSite"
label="Site"
placeHolder="Search for site"
label={t('Site', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/uploadForm.js
<SelectElement
name="instrument"
label="Instrument"
label={t('Instrument', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/uploadForm.js
<TextboxElement
name="pscid"
label="PSCID"
label={t('PSCID', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

driusan
driusan reviewed Aug 25, 2025
View reviewed changes
modules/document_repository/jsx/uploadForm.js
<TextboxElement
name="visitLabel"
label="Visit Label"
label={t('Visit Label', {ns: 'document_repository'})}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loris namespace

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Aug 26, 2025
@racostas
Copy link
Contributor

Hi @SKADE2303, please address @driusan comments, This are the same issues we disused in #9941. Correct me if I'm wrong but I think to remember we also had a meeting about it. This namespace issue have to be addressed in most of all PRs sent. Please take a careful look to each one again. Thank you.

@SKADE2303 SKADE2303 added State: Needs work PR awaiting additional work by the author to proceed and removed State: Needs work PR awaiting additional work by the author to proceed labels Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan left review comments

@racostas racostas Awaiting requested review from racostas

At least 1 approving review is required to merge this pull request.

Assignees

@racostas racostas

Labels
Event: GSOC PR or issue accepted for Google Summer of Code Language: Javascript PR or issue that update Javascript code Module: document_repository PR or issue related to documen_repository module Multilingual Any tasks related to making LORIS multilingual State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SKADE2303 @racostas @driusan