[Imaging_Uploader] Translate imaging_uploader module #9986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Language: Javascript
SKADE2303
added
Event: GSOC
SKADE2303
force-pushed
the
TranslateImagingUploader
branch
from
5232cd1 to
70476a0
Compare
racostas
requested changes
Sep 12, 2025
racostas
reviewed
Sep 12, 2025
| <TextboxElement | ||
| name='candID' | ||
| label='CandID' | ||
| label={t('CandID', {ns: 'loris'})} |
There was a problem hiding this comment.
I don't think we have this CandID in the loris.po yet.
There was a problem hiding this comment.
We have DCCID. We should probably harmonize.
racostas
reviewed
Sep 12, 2025
| {id: 'browse', label: 'Browse'}, | ||
| {id: 'upload', label: 'Upload'}, | ||
| {id: 'browse', label: t('Browse', {ns: 'loris'})}, | ||
| {id: 'upload', label: t('Upload', {ns: 'loris'})}, |
There was a problem hiding this comment.
I don't think we have Upload in the loris.po yet
racostas
reviewed
Sep 12, 2025
| <ButtonElement | ||
| type='reset' | ||
| label='Clear Filters' | ||
| label={t('Clear Filters', {ns: 'imaging_uploader'})} |
There was a problem hiding this comment.
Suggested change
| label={t('Clear Filters', {ns: 'imaging_uploader'})} | |
| label={t('Clear Filters', {ns: 'imaging_uploader'})} |
I think I have have see this 'Clear Filters' in other modules as well. Do we better put it as part of the loris.po ? What do you think @driusan ?
There was a problem hiding this comment.
I'm confused about it not being there because it already exists as marked up in jsx/Filter.js
racostas
added
the
State: Needs work
SKADE2303
removed
the
State: Needs work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module imaging_uploader to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)