Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Simplify JSON/Dictionary parsing logic #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmhowe425
Copy link
Contributor

Implementation in PR follows best practices mentioned here, and also improves code readability.

@rmhowe425
Copy link
Contributor Author

rmhowe425 commented Jul 14, 2024

@achillean Submitting a PR if interested!

There are a few other places in the code where dict.get() could be used to simplify the code, as mentioned in my reference to a open PR. I left this for the author of the PR to address if they want.

@rmhowe425 rmhowe425 changed the title ENH: Dev/simplify dictionary logic ENH: Simplify JSON/Dictionary parsing logic Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant