Skip to content
This repository was archived by the owner on Jun 6, 2020. It is now read-only.

Conversation

@nepeat
Copy link

@nepeat nepeat commented Aug 1, 2017

Before

image

After

image

@achow101
Copy link
Owner

achow101 commented Aug 3, 2017

What's the rationale for doing this?

@code-runner-77
Copy link

code-runner-77 commented Aug 3, 2017

Not a big deal but "less" is more. The word "Node" in the top of the card is superfluous since at the bottom of the card it says "Node Operational" or "Node ..". Another solution is to have more of a header at the top of the web page which seems to have no header or intro explanation saying these are all the main nodes or discussed BIP/forks of Bitcoin - then "Node" is definitely not needed in the card header... Looks better without it (the code looks correct but there is a typo in the After comment about where btc1 still says Node btc1).

@nepeat
Copy link
Author

nepeat commented Aug 3, 2017

Messed up my edits but my main reasoning for this at the time was because of scaling problems with certain display sizes and div height making the "Node Operational" green backgrounds stretch out except for the largest one as seen with Bitcoin Cash in the before image.

Now that there is an extra column for scheduled forks, this horrendous layout error happens instead.
image

@achow101
Copy link
Owner

achow101 commented Aug 3, 2017

It would be better if you could figure out how to line up the header and footers in the styling itself instead of changing the strings to make the styling match.

@code-runner-77
Copy link

code-runner-77 commented Aug 3, 2017

I think each card looks too crowded and the info is repeated in each card could be put once on the left side of the page. Might require a bit of rework.
e.g. Just noticed also questions do not have question marks "?" - Would be better if they did in my opinion -

Cross between card and table format

[Questions..../Labels] Card 1 Card 2 Card 3 Card 4
...
Has Experienced a Blockchain Reorginization**?**: No No No No
...
It looks like cards are set the width of the page - maybe they should all have an equal width?

And / Or put fewer cards in a row so that each card can be wider reducing line wraparound...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants