Skip to content

Fix #15 finding pane close + #16 Apps-over-Compare #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aclinick merged 1 commit into from
Jun 4, 2026
Merged

Fix #15 finding pane close + #16 Apps-over-Compare #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions MSIXplainer/MainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,8 @@
<!-- All findings -->
<TextBlock Text="All Findings" Style="{StaticResource SubtitleTextBlockStyle}" />

<ListView AutomationProperties.AutomationId="OverviewFindingsList"
<ListView x:Name="OverviewFindingsList"
AutomationProperties.AutomationId="OverviewFindingsList"
ItemsSource="{x:Bind ViewModel.CategoryFindings, Mode=OneWay}"
SelectedItem="{x:Bind ViewModel.SelectedFinding, Mode=TwoWay}"
SelectionMode="Single">
Expand Down Expand Up @@ -519,9 +520,10 @@
<!-- Close button -->
<Button AutomationProperties.AutomationId="BtnCloseFinding"
HorizontalAlignment="Right"
Command="{x:Bind ViewModel.DismissSelectedFindingCommand}"
Click="OnCloseFindingClick"
Padding="4" MinWidth="0" MinHeight="0"
Background="Transparent" BorderThickness="0">
Background="Transparent" BorderThickness="0"
ToolTipService.ToolTip="Close">
<FontIcon Glyph="&#xE711;" FontSize="12" />
</Button>

Expand Down
13 changes: 13 additions & 0 deletions MSIXplainer/MainPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ private async void NavView_ItemInvoked(NavigationView sender, NavigationViewItem
switch (invoked.Tag)
{
case "apps":
ExitCompareMode();
ExitSettingsMode();
await OpenAppsPaneAsync();
break;

Expand Down Expand Up @@ -195,6 +197,17 @@ private void ViewFinding_Click(object sender, RoutedEventArgs e)
ViewModel.SelectedFinding = finding;
}

/// <summary>
/// Closes the finding detail pane. Clears the OverviewFindingsList selection
/// explicitly first so the TwoWay binding can't immediately re-push the old
/// selection back into ViewModel.SelectedFinding once we null it.
/// </summary>
private void OnCloseFindingClick(object sender, RoutedEventArgs e)
{
OverviewFindingsList.SelectedItem = null;
ViewModel.SelectedFinding = null;
}

/// <summary>
/// Copies a manifest property value to the clipboard. Wraps the clipboard
/// call in try/catch so a transient clipboard failure never bubbles up as
Expand Down
Loading