Skip to content
This repository was archived by the owner on Aug 3, 2025. It is now read-only.

Fixes for lock and emacs#7

Open
silverdev wants to merge 4 commits into
acm-uiuc:masterfrom
silverdev:master
Open

Fixes for lock and emacs#7
silverdev wants to merge 4 commits into
acm-uiuc:masterfrom
silverdev:master

Conversation

@silverdev

Copy link
Copy Markdown
Member

The lock script was updated to work with gnome 3.10 and the emacs configs slowing becoming more usable and less buggy.

Comment thread commonsh/10_alias Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is peco supposed to be pico?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Steven! Do the think I should make a symlink from emacsrc to emacsrc.el?
I did not think it was needed because the emacs rc was buggy enough that I think no one uses it but Fab and I. Also emacs users are good at debugging init scrips and would quickly know to change their symlink. Still it would provide backwards compatibility for people who pull updates to acmdots.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well why are we changing it to have a .el extension? None of the other config files have extensions.

I wouldn't bother symlinking, though. It might prevent their config from breaking but it also means they won't get any of the updates and they might not realize that, which'd be worse. If anyone wants to pull updates from acmdots they'll need to re-run the install script.

My only other concern with the rename would be merge conflicts, but a symlink won't help with that. Git is probably smart enough to apply any changes to the renamed file, though.

Good catch Steven!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants