-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create new hack page #130
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for a new "hackutd" division and updates the winning projects page design for improved clarity. Key changes include additions to division utility types, updates to components (WinningProjects, Navigator, DivisionHeader, and a new HackHeader), and new configuration data for HackUTD.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/components/Divisions/Shared/divisionUtil.ts | Extended division types and helper functions to include "hackutd". |
src/components/Divisions/Shared/WinningProjects.tsx | Updated the component layout and allowed "hackutd" as a valid division. |
src/components/Divisions/Shared/Navigator.tsx | Added "hackutd" support by mapping to alternate links. |
src/components/Divisions/Shared/DivisionHeader.tsx | Added application URL and image mapping for "hackutd". |
src/components/Divisions/Hack/HackHeader.tsx | New header component dedicated to HackUTD. |
src/app/[...slug]/page.tsx | Integrated HackUTD routes and header components into the app routing. |
config/hack.config.ts | New configuration data for HackUTD including directors, testimony, FAQs, carousel images, and winners. |
config/divisions.config.ts | Updated divisions configuration to include "hackutd" across multiple functions. |
config/about.config.ts | Added a "learn more" link for HackUTD on the About page. |
Comments suppressed due to low confidence (2)
src/components/Divisions/Shared/WinningProjects.tsx:32
- [nitpick] Consider renaming the inner map's index variable to avoid reusing 'i' from the outer scope, which can improve clarity and prevent potential key conflicts.
{project.links.map((link, i) => (
config/divisions.config.ts:57
- Making the 'manager' property optional could affect downstream components that expect a defined value. Confirm that all usages of this field handle undefined values appropriately.
manager?: string;
Waiting on:
Decided to update the design for the winning projects page to make it look cleaner