Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create new hack page #130

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: create new hack page #130

wants to merge 6 commits into from

Conversation

RubenOlano
Copy link
Contributor

@RubenOlano RubenOlano commented Mar 18, 2025

Waiting on:

  • Experience
  • FAQ
  • Images
  • Winning Projects

Decided to update the design for the winning projects page to make it look cleaner

Copy link

vercel bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2025 3:41am

@RubenOlano RubenOlano marked this pull request as ready for review March 28, 2025 03:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for a new "hackutd" division and updates the winning projects page design for improved clarity. Key changes include additions to division utility types, updates to components (WinningProjects, Navigator, DivisionHeader, and a new HackHeader), and new configuration data for HackUTD.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/Divisions/Shared/divisionUtil.ts Extended division types and helper functions to include "hackutd".
src/components/Divisions/Shared/WinningProjects.tsx Updated the component layout and allowed "hackutd" as a valid division.
src/components/Divisions/Shared/Navigator.tsx Added "hackutd" support by mapping to alternate links.
src/components/Divisions/Shared/DivisionHeader.tsx Added application URL and image mapping for "hackutd".
src/components/Divisions/Hack/HackHeader.tsx New header component dedicated to HackUTD.
src/app/[...slug]/page.tsx Integrated HackUTD routes and header components into the app routing.
config/hack.config.ts New configuration data for HackUTD including directors, testimony, FAQs, carousel images, and winners.
config/divisions.config.ts Updated divisions configuration to include "hackutd" across multiple functions.
config/about.config.ts Added a "learn more" link for HackUTD on the About page.
Comments suppressed due to low confidence (2)

src/components/Divisions/Shared/WinningProjects.tsx:32

  • [nitpick] Consider renaming the inner map's index variable to avoid reusing 'i' from the outer scope, which can improve clarity and prevent potential key conflicts.
{project.links.map((link, i) => (

config/divisions.config.ts:57

  • Making the 'manager' property optional could affect downstream components that expect a defined value. Confirm that all usages of this field handle undefined values appropriately.
manager?: string;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create learn more page for HackUTD
1 participant