-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACMS-4234: Add config action to import core site studio packages. #1918
base: develop
Are you sure you want to change the base?
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
38eef86
to
61ae5e0
Compare
61ae5e0
to
f614115
Compare
f614115
to
f93d1fe
Compare
f88f4bc
to
78610ef
Compare
78610ef
to
4fa0610
Compare
4fa0610
to
132951b
Compare
132951b
to
9d126c2
Compare
9d126c2
to
1ae2970
Compare
…on to sub module.
1ae2970
to
7346984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new configuration action to import core Site Studio packages by defining a new service, module metadata, and a comprehensive package configuration.
- Registers a new service for default recipe packages.
- Introduces a new module with its info file.
- Adds a configuration file listing multiple package definitions for Site Studio.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
acquia_starterkit_site_studio.services.yml | Registers a new service for handling default recipe packages. |
acquia_starterkit_site_studio.info.yml | Adds the module metadata and dependency declaration. |
site_studio.packages.yml | Provides YAML configuration for multiple package imports for Site Studio. |
Files not reviewed (2)
- modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/src/Plugin/ConfigAction/BasePackageImport.php: Language not supported
- modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/src/Services/DefaultRecipePackage.php: Language not supported
Comments suppressed due to low confidence (2)
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/acquia_starterkit_site_studio.info.yml:7
- [nitpick] The dependency declaration uses the format 'module:machine_name' which might be confusing; please ensure that this naming convention aligns with project standards.
- acquia_cms_site_studio:acquia_cms_site_studio
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/config/site_studio/site_studio.packages.yml:33
- The recipe 'acquia_starterkit_image' is defined in two separate package blocks with different paths; please verify if this duplicate definition is intentional or if one should be renamed to avoid potential conflicts.
recipe_name: acquia_starterkit_image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a configuration action to import core Site Studio packages into the Acquia CMS system. The changes include defining package configurations in a YAML file, registering a new service for handling default recipe packages, and creating a module info file.
- Introduces a YAML configuration file for package definitions.
- Adds a service definition for default recipe packages.
- Adds a module info file to support the new package import functionality.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
File | Description |
---|---|
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/config/site_studio/site_studio.packages.yml | Defines package configurations for core Site Studio packages. |
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/acquia_starterkit_site_studio.services.yml | Registers a new service for default recipe packages. |
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/acquia_starterkit_site_studio.info.yml | Provides module metadata and dependencies. |
Files not reviewed (2)
- modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/src/Plugin/ConfigAction/BasePackageImport.php: Language not supported
- modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/src/Services/DefaultRecipePackage.php: Language not supported
Comments suppressed due to low confidence (3)
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/config/site_studio/site_studio.packages.yml:43
- [nitpick] The recipe name 'acquia_starterkit_image' is used in two package entries with different paths. Consider renaming one (for example, adding a '_core' suffix) to clearly differentiate their intended usage.
recipe_name: acquia_starterkit_image
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/config/site_studio/site_studio.packages.yml:75
- [nitpick] The recipe name 'acquia_starterkit_place' is used for both the primary and search variant packages. Consider renaming the search variant (e.g. 'acquia_starterkit_place_search') for added clarity.
recipe_name: acquia_starterkit_place
modules/acquia_cms_site_studio/modules/acquia_starterkit_site_studio/config/site_studio/site_studio.packages.yml:97
- [nitpick] The recipe name 'acquia_starterkit_event' is repeated for both the main and search variant packages. Renaming one of them (for example, appending '_search' to the search variant) could prevent confusion.
recipe_name: acquia_starterkit_event
Motivation
Fixes #ACMS-4234
Proposed changes
Config action to import core site studio packages.
Alternatives considered
NA
Testing steps
Follow from ticket.
Merge requirements