Skip to content
This repository was archived by the owner on Nov 16, 2021. It is now read-only.

Conversation

@phenaproxima
Copy link
Collaborator

This PR provides the very early alpha of a simple Media Library plugin for CKEditor.

The media library is opened in a modal dialog box by a button in the CKE toolbar, and rendered client-side using Backbone. The items in the media library are fetched over AJAX using a view (which in turn causes the lightning_media module to rely on the core REST and Serialization modules), and when clicked they are directly embedded into the CKEditor document using Entity Embed. It just works.

drupal-media/entity_embed#189 is related to this here PR. I don't think it's an outright dependency, but this work resulted in that patch.

Right now, the media library button will need to be added manually to a CKEditor configuration (and entity embedding will need to be enabled for the text format). Later we can maybe add that as a default to (certain? all?) text formats included with Lightning.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think all of the media entity plugins need to be requirements here. Please add:

  • media_pinkeye
  • media_entity_slideshow
  • media_entity_instagram
  • media_entity_twitter
  • media_entity_image

balsama added a commit that referenced this pull request Nov 12, 2015
Media Library plugin for CKEditor
@balsama balsama merged commit c809954 into acquia:8.x-1.x Nov 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this need to define a new embed type when you're basically embedding entities (which should be supported by Entity Embed, and adding a button to embed media_entity entities)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just future-proofing on my part so that we have extra flexibility if we need it. But yes, at the moment we're not doing anything dramatically different from what Entity Embed already does.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants