Skip to content

RSpec 3 compatibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RSpec 3 compatibility #25

wants to merge 3 commits into from

Conversation

sgerrand
Copy link

@sgerrand sgerrand commented Jun 9, 2015

💁 These changes are designed to update the test suite to be compatible with RSpec v3.

  • changed mock to double (rspec-mocks compatibility)
  • changed stub to allow (rspec-expectations compatibility)
  • removed include Kafka from spec/spec_helper.rb
  • changed test hierarchy to match classes under test

I've also added a Travis CI configuration file to enable testing the library across a matrix of MRI Ruby versions.

sgerrand added 3 commits June 9, 2015 11:14
Updated the existing RSpec tests to run under RSpec 3. Changed use of `mock` and
`stub` to use `double` and `allow` methods from rspec-mocks and
rspec-expectations, respectively.
Updated the deprecated 's' format shorthand for documentation output.
Move specs to match class hierarchy and removed `include Kafka` to enforce
test isolation.
@sgerrand
Copy link
Author

sgerrand commented Jun 9, 2015

👋 @acrosa: Would you please review these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant