feat: Added foundry deploy script

[fusmanii]

First attempt at deploy script migration to foundry. Just did one deploy script and looking for feedback.

List of changes:

• Created DeployHubPool.s.sol and script/DeployEthereumSpokePool.s.sol inside script folder
• Created DeployConstants.sol inside script folder that works similar to deploy/consts.ts by providing third party smart contract addresses
• Created DeploymentUtils.sol inside script that works similar to utils/utils.hre.ts
• Contract can be deployed using forge script script/DeployHubPool.s.sol:DeployHubPool --rpc-url $RPC_URL --broadcast --verify -vvvv which deploys and verifies the contract and adds the deploy info in the broadcast folder
• Created a script script/extract_foundry_addresses.sh that extracts all the deployed addresses from the broadcast folder and puts it in a json, an md file and a sol file (similar to deployments.json)

Looking for feedback on the proposed flow and how I can make this better and address some of the short comings of the current deployment flow

Fixes https://linear.app/uma/issue/UMA-2906/contracts-migrate-smart-contract-deploy-to-foundry

[nicholaspai]

I think this is a great start.

[mrice32]

Could we read this in via one or more json configuration files? Two advantages:

• Config/code split so it's clear (in the future) which changes are configuration and which changes are logical.
• More flexibility: it will allow us to pull in this info from somewhere else easily. For instance, the json could be generated/updated from an API OR we could import one or more of the config jsons from a common package (like our constants package or something).

Thoughts?

[fusmanii]

Mainly because dealing with json inside a foundry script is not trivial, I also have deployed-addresses.json that is generated regarding your second point

[mrice32]

Don't they have utilities for that that makes it fairly trivial if the json is well structured? I may be missing some additional complexity (I haven't tried to use these utils before)

https://getfoundry.sh/reference/cheatcodes/parse-json/?highlight=json
https://getfoundry.sh/reference/cheatcodes/parse-json-keys

[fusmanii]

updated to using perse-json, much cleaner now :)

[mrice32]

Thoughts on expanding this, s.t. the Constants.sol values are read in from json as well?

[fusmanii]

Constants are currently in a ts file, but I can create a json for constants that Constants.sol uses

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​openzeppelin/​foundry-upgrades@​0.4.0

View full report

[linear]

UMA-2906 [contracts] Migrate smart contract deploy to foundry

[mrice32]

#1044 (comment)