chore: Bump node 16 (20) -> 22 #1065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linea SDK is a painful dependency in that it depends on better-sqlite3, and that seems to have build issues when migrating to node 22. The Linea SDK is only required here for a single script that's never actually been needed in production. To simplify things, we can migrate it to the relayer repository where we already have to deal with the Linea SDK dependencies.
16 is long EoL but we were in practice using 20 in CI.
pxrl
commented
Aug 14, 2025
| if command -v node >/dev/null 2>&1; then | ||
| if node --version 2>/dev/null | grep -q "v${{ inputs.node_version }}"; then |
There was a problem hiding this comment.
This pre-existing check would resolve true if the installed version of node was different to what was specified via inputs.node_version. Harden it a bit by verifying that the actual installed version of node reports something that gives a strong hint at being the right version. This should be compatible with specifying additional constraints on the version - i.e. minor and patch levels.
I wonder if there's a cleaner way to do this - i.e. I'd suspect setup-node has some built-in version checker, but since action was only recently by @Reinis-FRP I'm assuming there was some blocker there.
nicholaspai
previously approved these changes
Aug 14, 2025
fusmanii
previously approved these changes
Aug 14, 2025
pxrl
dismissed stale reviews from fusmanii and nicholaspai
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
16 is long EoL but we were in practice using 20 in CI.