Skip to content

feat: deploy scroll, blast, mode, redstone, zora, ink, lens, and soneium spoke pools #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: deploy scroll, blast, mode, redstone, zora, ink, lens, and soneium spoke pools #1081

wants to merge 14 commits into from

Conversation

bmzig
Copy link
Contributor

@bmzig bmzig commented Aug 25, 2025

No description provided.

@fusmanii fusmanii force-pushed the faisal/foundry-migration-deploy-scripts branch from 3c02f42 to 56637f5 Compare August 25, 2025 22:09
@fusmanii fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from d19e0d1 to af5979f Compare August 26, 2025 14:08
Base automatically changed from faisal/foundry-migration-deploy-scripts to faisal/foundry-migration-deployment-utils August 26, 2025 14:51
Base automatically changed from faisal/foundry-migration-deployment-utils to faisal/foundry-migration-constants August 26, 2025 14:58
@fusmanii fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from 9ff6088 to 676fbb3 Compare August 26, 2025 15:24
@fusmanii fusmanii changed the title feat: deploy scroll, blast, zora, and ink feat: deploy scroll, blast, mode, redstone, zora, ink, lens, and soneium spoke pools Aug 26, 2025
nicholaspai
nicholaspai previously approved these changes Aug 26, 2025
View reviewed changes
nicholaspai
nicholaspai reviewed Aug 26, 2025
View reviewed changes
script/utils/ExtractDeployedFoundryAddresses.ts Outdated
@@ -373,7 +373,7 @@ function generateAddressesFile(broadcastFiles: BroadcastFile[], outputFile: stri
}
}

content.push("");
// content.push("");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6c1bfd2

@grasphoper
Copy link
Contributor

Do we want to put these new addresses into deployments.json for backward compatibility for now? AFAIK, bits of relayer code rely on deployments.json being a source of truth.

Otherwise when bumping the contracts version in the relayer, we need to handle these changes in ContractUtils.ts

Base automatically changed from faisal/foundry-migration-constants to master August 26, 2025 16:58
@fusmanii fusmanii dismissed nicholaspai’s stale review August 26, 2025 16:58

The base branch was changed.

@fusmanii
Copy link
Contributor

@grasphoper I was hoping to make the new broadcast/deployed-addresses.json as source of truth since it has all the addresses from deployments.json and all new deploys from broadcast

also its automatically kept up to date by with extract-addresses script

@fusmanii fusmanii requested a review from nicholaspai August 26, 2025 17:42
@fusmanii fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from 681c342 to a460888 Compare August 27, 2025 18:59
@pxrl
Copy link
Contributor

pxrl commented Aug 29, 2025

Do we want to put these new addresses into deployments.json for backward compatibility for now? AFAIK, bits of relayer code rely on deployments.json being a source of truth.

Otherwise when bumping the contracts version in the relayer, we need to handle these changes in ContractUtils.ts

These are only implementation contracts so we don't actually want them in deployments.json - if we updated them there then it'd break the bots.

fusmanii and others added 8 commits August 29, 2025 17:07
@fusmanii
Added address extraction script
741f615 
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii
Renamed readme
9fa7137 
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii
feat(Foundry): Added hubpool, ethereum and arbitrum spoke pool scripts
a8879b2 
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii
Renamed arb deploy script
7dc3fce 
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii
Added deploy scripts for v4 upgrades
17308d2 
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii
Deployed mode, redstone, lens and soneium spoke pools
d4a9e57 
Signed-off-by: Faisal Usmani <[email protected]>
@fusmanii
Revert "Deployed mode, redstone, lens and soneium spoke pools"
88ebaec 
This reverts commit 8ccecb1.

Signed-off-by: Faisal Usmani <[email protected]>
@bmzig @fusmanii
deploy scroll, blast, zora, and ink
482305c 
Signed-off-by: bennett <[email protected]>
bmzig and others added 5 commits August 29, 2025 17:08
@fusmanii
Add the extra # back
4e83ba9 
Signed-off-by: Faisal Usmani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fusmanii fusmanii fusmanii left review comments

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmzig @grasphoper @fusmanii @pxrl @nicholaspai