feat: Added upgradeToAndCall to Spoke Pool Upgrade task #1095
+28
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Usmani <[email protected]>
fusmanii
force-pushed
the
faisal/try-upgradeTo
branch
from
462340a to
4b60fdd
Compare
Signed-off-by: Faisal Usmani <[email protected]>
Signed-off-by: Faisal Usmani <[email protected]>
fusmanii
force-pushed
the
faisal/try-upgradeTo
branch
from
2e4e5ce to
acb0084
Compare
fusmanii
changed the title
Signed-off-by: Faisal Usmani <[email protected]>
fusmanii
changed the title
fusmanii
requested review from
mrice32,
nicholaspai,
pxrl and
bmzig
as code owners
nicholaspai
reviewed
Sep 3, 2025
Co-authored-by: nicholaspai <[email protected]> Signed-off-by: Faisal Usmani <[email protected]>
fusmanii
force-pushed
the
faisal/try-upgradeTo
branch
from
0d5917e to
3520c92
Compare
pxrl
reviewed
Sep 4, 2025
tasks/upgradeSpokePool.ts
Outdated
| @@ -17,13 +18,75 @@ task("upgrade-spokepool", "Generate calldata to upgrade a SpokePool deployment") | |||
| } | |||
|
|
|||
| // @dev Any spoke pool's interface can be used here since they all should have the same upgradeTo function signature. | |||
| const abi = ["function upgradeTo(address newImplementation) external"]; | |||
| const abi = [ | |||
There was a problem hiding this comment.
ooc, can we draw on the ABI via typechain?
I'm generally pretty wary of using typechain, but given that the ABI is local to this repo it feels like we should be able to source it from somewhere dynamically, rather than have to redefine it.
There was a problem hiding this comment.
@pxrl good point, I was able to get the abi directly from the artifact instead
pxrl
reviewed
Sep 4, 2025
| @@ -3,8 +3,9 @@ import { HardhatRuntimeEnvironment } from "hardhat/types"; | |||
|
|
|||
| task("upgrade-spokepool", "Generate calldata to upgrade a SpokePool deployment") | |||
| .addParam("implementation", "New SpokePool implementation address") | |||
| .addOptionalParam("upgradeOnly", "Upgrade only, do not pause/unpause deposits") | |||
There was a problem hiding this comment.
Do you think there's a scenario where we wouldn't want the atomic pause/unpause?
There was a problem hiding this comment.
On EVM chains we are absolutely sure there is no difference from the L1 EVM
There was a problem hiding this comment.
I just kept it in case someone is looking for the old upgrade only behaviour. @pxrl do you think its better (and safer) to only have atomic pause/unpause option?
pxrl
reviewed
Sep 4, 2025
Comment on lines
+71
to
+83
| /** | ||
| * We perform this seemingly unnecessary pause/unpause sequence because we want to ensure that the | ||
| * upgrade is successful and the new implementation gets forwarded calls by the proxy contract as expected | ||
| * | ||
| * Since the upgrade and call happens atomically, the upgrade will revert if the new implementation | ||
| * is not functioning correctly. | ||
| */ | ||
| const data = spokePool.interface.encodeFunctionData("multicall", [ | ||
| [ | ||
| spokePool.interface.encodeFunctionData("pauseDeposits", [true]), | ||
| spokePool.interface.encodeFunctionData("pauseDeposits", [false]), | ||
| ], | ||
| ]); |
Signed-off-by: Faisal Usmani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that the new implementation is working as expected by toggling
pauseDepositsfunction post upgrade