feat: Generated the constants file #1096

fusmanii · 2025-09-03T01:59:58Z

All constants are taken from constants repo so that there is only one source of truth

Signed-off-by: Faisal Usmani <[email protected]>

pxrl · 2025-09-04T14:15:13Z

script/utils/GenerateConstantsJson.ts

+  QUOTE_TIME_BUFFER,
+  FILL_DEADLINE_BUFFER,
+  ARBITRUM_MAX_SUBMISSION_COST,
+  AZERO_GAS_PRICE,


We can probably drop references to Aleph Zero because the Aleph Zero deployment is EoL now.

done 791d7e7

pxrl · 2025-09-04T14:16:37Z

script/utils/GenerateConstantsJson.ts

+}
+
+// Helper function to extract wrapped native tokens from TOKEN_SYMBOLS_MAP
+function extractWrappedNativeTokens(): { [key: string]: string } {


In the constants repo we define the native token symbol for each chain - feels like we could use that here to do something a bit more dynamic.

I was able to remove this function all together: 791d7e7

pxrl · 2025-09-04T14:17:28Z

script/utils/GenerateConstantsJson.ts

+function extractUsdceAddresses(): { [key: string]: string } {
+  const result: { [key: string]: string } = {};
+
+  for (const [chainId, address] of Object.entries(USDCe)) {


I don't think this is super reliable because the USDC symbol itself can be quite random. Zora has USDzC for example.

pxrl · 2025-09-04T14:18:11Z

script/utils/GenerateConstantsJson.ts

+}
+
+// Helper function to extract WGHO addresses
+function extractWghoAddresses(): { [key: string]: string } {


Integrating nativeToken from the constants repo would probably also help to remove a bespoke function like this one.

pxrl · 2025-09-04T14:19:17Z

script/utils/GenerateConstantsJson.ts

+    if (hubChainName) {
+      result[hubChainName] = {};
+      for (const [spokeChainId, addresses] of Object.entries(spokeChains)) {
+        const spokeChainName = Object.keys(CHAIN_IDs).find(
+          (key) => CHAIN_IDs[key as keyof typeof CHAIN_IDs] === Number(spokeChainId)
+        );
+        if (spokeChainName) {
+          result[hubChainName][spokeChainName] = addresses;
+        }
+      }
+    }


Thoughts on dropping the indentation by returning early if hubChainName is not defined?

pxrl · 2025-09-04T14:20:14Z

script/utils/GenerateConstantsJson.ts

+  for (const [chainId, domainId] of Object.entries(CIRCLE_DOMAIN_IDs)) {
+    const chainName = Object.keys(CHAIN_IDs).find(
+      (key) => CHAIN_IDs[key as keyof typeof CHAIN_IDs] === Number(chainId)
+    );
+    if (chainName) {
+      result[chainName] = domainId;
+    }
+  }


This pattern is a bit repetitive now - is there maybe some way to refactor such that the core functionality is generic? Or are the upstream objects themselves too bespoke for that?

pxrl · 2025-09-04T14:20:38Z

script/utils/GenerateConstantsJson.ts

+      QUOTE_TIME_BUFFER: QUOTE_TIME_BUFFER,
+      FILL_DEADLINE_BUFFER: FILL_DEADLINE_BUFFER,


Suggested change

QUOTE_TIME_BUFFER: QUOTE_TIME_BUFFER,

FILL_DEADLINE_BUFFER: FILL_DEADLINE_BUFFER,

QUOTE_TIME_BUFFER,

FILL_DEADLINE_BUFFER,

done: 791d7e7

pxrl · 2025-09-04T14:22:12Z

script/utils/constants.json

+    "LENS": -1,
+    "BOBA": -1,


ooc, rather than enumerating each chain w/ -1 for no OFT EID, could we just omit chains without an OFT EID?

good point, done: 791d7e7

pxrl · 2025-09-04T14:23:17Z

script/utils/constants.json

-    "POLYGON": "0x0d500B1d8E8eF31E21C99d1Db9A6444d3ADf1270",
-    "POLYGON_AMOY": "0xA5733b3A8e62A8faF43b0376d5fAF46E89B3033E",
-    "ZK_SYNC": "0x5AEa5775959fBC2557Cc8789bC1bf90A239D9a91",
    "OPTIMISM": "0x4200000000000000000000000000000000000006",
-    "OPTIMISM_SEPOLIA": "0x74A4A85C611679B73F402B36c0F84A7D2CcdFDa3",
-    "BASE": "0x4200000000000000000000000000000000000006",
-    "BASE_SEPOLIA": "0x999B45BB215209e567FaF486515af43b8353e393",
-    "LENS": "0x6bDc36E20D267Ff0dd6097799f82e78907105e2F",
-    "LINEA": "0xe5D7C2a44FfDDf6b295A15c148167daaAf5Cf34f",
-    "LINEA_SEPOLIA": "0x10253594A832f967994b44f33411940533302ACb",
-    "SCROLL_SEPOLIA": "0x5300000000000000000000000000000000000004",
-    "SCROLL": "0x5300000000000000000000000000000000000004",
+    "BSC": "0x2170Ed0880ac9A755fd29B2688956BD959F933F8",
    "UNICHAIN": "0x4200000000000000000000000000000000000006",
-    "UNICHAIN_SEPOLIA": "0x4200000000000000000000000000000000000006",
-    "ALEPH_ZERO": "0xB3f0eE446723f4258862D949B4c9688e7e7d35d3",
-    "BLAST": "0x4300000000000000000000000000000000000004",
-    "BLAST_SEPOLIA": "0x4200000000000000000000000000000000000023",
+    "POLYGON": "0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619",


We have different addresses for Polygon here - the new address is incorrect because it's WETH.

pxrl · 2025-09-04T14:24:42Z

script/utils/constants.json

-      "cctpMessageTransmitter": "0x0a992d191DEeC32aFe36203Ad87D7d289a738F81",
+      "cctpMessageTransmitter": "0x0a992d191deec32afe36203ad87d7d289a738f81",


It could be a good idea to split simple changes like this out to a separate PR - that'll help reduce the diff here and make it easier to review the subsequent address changes.

bmzig · 2025-09-04T15:02:06Z

script/utils/GenerateConstantsJson.ts

+}
+
+// Helper function to extract USDC addresses
+function extractUsdcAddresses(): { [key: string]: string } {


Two questions for this entire file:

Why are we setting the keys as the chain name? I would think it's a lot easier for foundry to know the network's chainId over the name of the network itself?

Maybe a stupid question, but these functions seem really complex for what they are doing. Why can't we just call JSON.stringify(USDC) and similar things for all of these other functions? I think adding this much code to just extract values from a map makes the script itself pretty rigid/hard to maintain.

Good idea, I updated the scripts to fetch by chainid instead 4677066

make every a lot cleaner

Signed-off-by: Faisal Usmani <[email protected]>

socket-security · 2025-09-05T14:57:46Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Quality
	form-data@4.0.0
	protobufjs@7.2.4 ⏵ 7.1.2	⁺¹
	elliptic@6.5.4 ⏵ 6.5.7	⁺¹
	testrpc@0.0.1
	ethereum-protocol@1.0.1
	isarray@2.0.5
	side-channel@1.0.4
	hasown@2.0.2
	jsonify@0.0.1 ⏵ 0.0.0	^-5	^-10
	has-tostringtag@1.0.2
	has-property-descriptors@1.0.2
	set-function-length@1.2.2
	minimalistic-assert@1.0.1
	gopd@1.2.0
	es-define-property@1.0.1
	typed-array-buffer@1.0.3
	has-symbols@1.1.0
	object.assign@4.1.0
	function-bind@1.1.2
	safe-buffer@5.2.1
	json-stable-stringify@1.3.0 ⏵ 1.0.1	⁺¹
	for-each@0.3.5
	which-typed-array@1.1.19
	object-assign@4.1.1
	is-typed-array@1.1.15
	ghost-testrpc@0.0.2
	is-fn@1.0.0
	imul@1.0.1
	escape-string-regexp@1.0.5
	is-stream-ended@0.1.4
	crypt@0.0.2
	fake-merkle-patricia-tree@1.0.1
	set-immediate-shim@1.0.1
See 370 more rows in the dashboard

View full report

socket-security · 2025-09-05T14:57:48Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		`[email protected]` has a Critical CVE. CVE: GHSA-95m3-7q98-8xr5 sha.js is missing type checks leading to hash rewind and passing on crafted data (CRITICAL) Affected versions: < 2.4.12 Patched version: 2.4.12 From: yarn.lock → `npm/[email protected]` → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is a critical CVE? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		`[email protected]` has Obfuscated code. Confidence: 0.94 Location: Package overview From: yarn.lock → `npm/[email protected]` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `[email protected]`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/[email protected]`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Signed-off-by: Faisal Usmani <[email protected]>

feat: Generated the constants file

e78b1e9

Signed-off-by: Faisal Usmani <[email protected]>

fusmanii force-pushed the faisal/generate-constants-json branch from 98dcbfa to e78b1e9 Compare September 3, 2025 02:00

fusmanii marked this pull request as ready for review September 4, 2025 14:05

fusmanii requested review from mrice32, nicholaspai, pxrl and bmzig as code owners September 4, 2025 14:05

pxrl reviewed Sep 4, 2025

View reviewed changes

bmzig reviewed Sep 4, 2025

View reviewed changes

fusmanii added 3 commits September 4, 2025 17:30

Using const variable directly

791d7e7

Signed-off-by: Faisal Usmani <[email protected]>

Updated Constans.sol script to read by chainid instead of chain name

4677066

Signed-off-by: Faisal Usmani <[email protected]>

Updated constants.json keys

ae04d5f

Signed-off-by: Faisal Usmani <[email protected]>

fusmanii force-pushed the faisal/generate-constants-json branch from 56f1e0f to ae04d5f Compare September 5, 2025 14:57

Updated weth method name

ff0e925

Signed-off-by: Faisal Usmani <[email protected]>

		QUOTE_TIME_BUFFER: QUOTE_TIME_BUFFER,
		FILL_DEADLINE_BUFFER: FILL_DEADLINE_BUFFER,

		"cctpMessageTransmitter": "0x0a992d191DEeC32aFe36203Ad87D7d289a738F81",
		"cctpMessageTransmitter": "0x0a992d191deec32afe36203ad87d7d289a738f81",

feat: Generated the constants file #1096

Are you sure you want to change the base?

feat: Generated the constants file #1096

Uh oh!

Conversation

fusmanii commented Sep 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Sep 5, 2025 •

edited

Loading

socket-security bot commented Sep 5, 2025 •

edited

Loading