feat: allow granular min deposit config #1641
Open
+50
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dohaki
requested review from
amateima,
ashwinrava,
james-a-morris,
melisaguevara,
mrice32,
nicholaspai and
pxrl
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
melisaguevara
approved these changes
Jun 26, 2025
ashwinrava
approved these changes
Jun 26, 2025
| inputTokenSymbol: string | ||
| ) { | ||
| const { MIN_DEPOSIT_USD, MIN_DEPOSIT_USD_OVERRIDES } = getEnvs(); | ||
| const minDepositUsdOverrides = JSON.parse( |
There was a problem hiding this comment.
Since we're using a nested JSON in an environment variable, it could be useful to wrap this in a try-catch (or maybe in a new util function like safeParse which does this) in case the type check fails at runtime. Or maybe it's not needed if we don't expect the environment variable to change much - just a thought.
ashwinrava
reviewed
Jun 26, 2025
Comment on lines
+586
to
+589
| routes?: { [key: string]: string }; | ||
| originChains?: { [key: string]: string }; | ||
| destinationChains?: { [key: string]: string }; | ||
| tokens?: { [key: string]: string }; |
There was a problem hiding this comment.
Think this type could be reusable for other overrides? I like how it goes from most specific to least specific. (Token + Chain) -> (Token) -> (Chain).
james-a-morris
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.