Skip to content

feat: twitter share #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Sep 5, 2025
Merged

feat: twitter share #1642

merged 47 commits into from
Sep 5, 2025

Conversation

gsteenkamp89
Copy link
Contributor

@gsteenkamp89 gsteenkamp89 commented Jun 26, 2025 •
edited
Loading

closes ACX-3968

Outstanding Items

  • Final tweet copy
  • Style redirect link

@gsteenkamp89
add canvas dep
577c14b 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
draw base layer image, serve with page & necessary tags
1262125 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add unstyled component. build URL
34297ad 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
style banner
47f4f6c 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@vercel Vercel
Copy link

vercel bot commented Jun 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
app-frontend-v3 Ready Ready Preview Comment Sep 5, 2025 11:53am
sepolia-frontend-v3 Ready Ready Preview Comment Sep 5, 2025 11:53am

@linear Linear
Copy link

linear bot commented Jun 26, 2025

ACX-3968 Add Twitter Share on confirmation screen

@gsteenkamp89
fixup
dad022d 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fix
0612b9b 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fixes
1e2bab7 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add transitive system deps for canvas
2c8fb3e 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add canvas as a dev dependency
6d31ea4 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
test new dimensions
d2b7406 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
square image
e9cda1a 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
serve better html
47550f7 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fixup
7451509 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89 gsteenkamp89 marked this pull request as ready for review June 30, 2025 15:56
@vercel vercel bot temporarily deployed to Preview – sepolia-frontend-v3 September 1, 2025 09:45 Inactive
@gsteenkamp89
use ready as default state
439e2ff 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
Merge branch 'master' into feat/twitter-share
1e86580 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
increase image scale
ee831c5 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
fixup
1e5f0e1 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
dynamic copy based on env var
1a17be7 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
edit copy
4571cca 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
add solana icon
f58fd1e 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89
update solana icon
938532b 
Signed-off-by: Gerhard Steenkamp <[email protected]>
@gsteenkamp89 gsteenkamp89 changed the title Feat/twitter share feat: twitter share Sep 5, 2025
james-a-morris
james-a-morris approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is largely the same set of changes sans the new designs. Great work

@gsteenkamp89 gsteenkamp89 merged commit 72b4566 into master Sep 5, 2025
10 checks passed
@gsteenkamp89 gsteenkamp89 deleted the feat/twitter-share branch September 5, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@nicholaspai nicholaspai Awaiting requested review from nicholaspai nicholaspai is a code owner

@dohaki dohaki Awaiting requested review from dohaki dohaki is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@melisaguevara melisaguevara Awaiting requested review from melisaguevara melisaguevara is a code owner

@amateima amateima Awaiting requested review from amateima amateima is a code owner

@ashwinrava ashwinrava Awaiting requested review from ashwinrava ashwinrava is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteenkamp89 @james-a-morris