feat: reduce RPC usage in API #1693
Open
+125
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Rice <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Matt Rice <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
Signed-off-by: Matt Rice <[email protected]>
mrice32
requested review from
nicholaspai,
dohaki,
james-a-morris,
pxrl,
melisaguevara,
amateima and
ashwinrava
as code owners
Signed-off-by: Matt Rice <[email protected]>
dohaki
previously approved these changes
Jul 31, 2025
api/_utils.ts
Outdated
| @@ -1300,7 +1302,8 @@ function getProviderFromConfigJson( | |||
| 3, // max. concurrency used in `SpeedProvider` | |||
| 5, // max. concurrency used in `RateLimitedProvider` | |||
| "RPC_PROVIDER", // cache namespace | |||
| 1 // disable RPC calls logging | |||
| 0, // disable RPC calls logging | |||
| redisCache | |||
There was a problem hiding this comment.
Could you verify that something gets written to Upstash?
There was a problem hiding this comment.
Good point, doesn't look like it is from the preview. Will take a pass tonight to figure out why.
There was a problem hiding this comment.
Okay, the issue was fixed. We needed a distance from HEAD.
Fixing this revealed some issues related to differences from our regular redis client vs the upstash one. For some reason, I'm seeing it strip quote characters (which breaks the provider caching). I was able to put in a workaround, but PTAL and let me know if you have a better idea.
| @@ -355,7 +353,10 @@ export async function extractDepositDataStruct( | |||
| exclusiveRelayer: | |||
| crossSwapQuotes.bridgeQuote.suggestedFees.exclusiveRelayer, | |||
| quoteTimestamp: crossSwapQuotes.bridgeQuote.suggestedFees.timestamp, | |||
| fillDeadline: await getFillDeadline(spokePool), | |||
| fillDeadline: getFillDeadline( | |||
melisaguevara
previously approved these changes
Jul 31, 2025
Signed-off-by: Matt Rice <[email protected]>
pxrl
previously approved these changes
Sep 4, 2025
dohaki
dismissed stale reviews from pxrl, melisaguevara, and themself
via
09e134a
dohaki
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes three changes to reduce RPC usage in the API: