feat(MulticallerClient): Allow caller to use PermissionedMulticaller #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be used to batch txns to contracts that whitelist the msg.sender
grasphoper
force-pushed
the
permissioned-multicall3
branch
from
1435f8c to
d304af5
Compare
grasphoper
reviewed
May 5, 2025
| @@ -272,12 +284,17 @@ export class MultiCallerClient { | |||
| const callData: Multicall2Call[] = []; | |||
| let gasLimit: BigNumber | undefined = bnZero; | |||
| transactions.forEach((txn, idx) => { | |||
| if (!txn.unpermissioned || txn.chainId !== chainId) { | |||
| if (!txn.unpermissioned || !txn.sendThroughPermissionedMulticall || txn.chainId !== chainId) { | |||
There was a problem hiding this comment.
Is this correct?
This check seems to be saying: "if any of the txns in transactions required permissions => throw". But this is not what we're going for with the PermissionedMulticall?
There was a problem hiding this comment.
Before we fix it here, let's first discuss our strat for using this in finalizer in Slack
There was a problem hiding this comment.
right, should be:
Suggested change
| if (!txn.unpermissioned || !txn.sendThroughPermissionedMulticall || txn.chainId !== chainId) { | |
| if (!(txn.unpermissioned || txn.sendThroughPermissionedMulticall) || txn.chainId !== chainId) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to batch txns to contracts that whitelist the msg.sender
Depends on across-protocol/sdk#1017