chore: Remove .toNative() from logger calls #2511
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusmanii
requested review from
mrice32,
nicholaspai,
pxrl,
james-a-morris,
dohaki and
bmzig
as code owners
|
@fusmanii have you confirmed that this is the case? (That the .toNative() is not required) I remember hitting some instances of full JSON object properties logging for |
I've also noticed this - we currently have an issue with an error message dumping the full Address class. I'm not 100% sure, but I think it might be an issue when an Address class is supplied directly as a logging argument, vs. when it's bundled inside another object. Needs further investigation to confirm. |
fusmanii
force-pushed
the
faisal/remove-tonative-from-logs
branch
from
a4324db to
93b4d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With across-protocol/sdk#1169
.toNative()for addresses in logger is redundant