Skip to content

improve: add solana withdrawal step to finalizer #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 24, 2025
Merged

improve: add solana withdrawal step to finalizer #2552

merged 18 commits into from
Sep 24, 2025

Conversation

@bmzig
Copy link
Contributor

@bmzig bmzig commented Sep 4, 2025 •
edited
Loading

I plan on marking this ready for review/bumping the sdk once I can test this works locally.

@bmzig bmzig mentioned this pull request Sep 5, 2025
Closed
@bmzig
Copy link
Contributor Author

bmzig commented Sep 22, 2025

Can confirm this works as intended now:

(Finalizer#CCTPL2ToL1Finalizer:34268394551451)⭢Withdrew 231,439.08 USDC from Solana to the hub pool.
• signature: 2f2itPwyG9dbbqQUz43aZk5PjranoBYD22fHiuMCFuuyctxqzrKG8qRMxsXucf3B1rbcK1FsBMS14eahTEneRjfE

and then

Finalized Solana withdrawal on Mainnet for 231,439.08 USDC :boomerang:
• txnRefList:
- 0: [0x2..e07](https://etherscan.io/tx/0x23f62b4e295d720e72d8af11eca7c56a16df686aa794e63a68cf787998bafe07)

@bmzig bmzig marked this pull request as ready for review September 22, 2025 14:03
dijanin-brat
dijanin-brat reviewed Sep 24, 2025
View reviewed changes
dijanin-brat
dijanin-brat previously approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@dijanin-brat dijanin-brat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a minor style comment

@bmzig
comment
a878a6d 
Signed-off-by: bennett <[email protected]>
pxrl
pxrl previously approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor comments, but LGTM either way.

@bmzig
fix
2a9aa09 
Signed-off-by: bennett <[email protected]>
@bmzig bmzig requested review from dijanin-brat and pxrl September 24, 2025 14:18
nicholaspai
nicholaspai reviewed Sep 24, 2025
View reviewed changes
@bmzig bmzig merged commit df74f57 into master Sep 24, 2025
4 checks passed
@bmzig bmzig deleted the bz/solanaStep branch September 24, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@james-a-morris james-a-morris Awaiting requested review from james-a-morris

@dohaki dohaki Awaiting requested review from dohaki dohaki is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@dijanin-brat dijanin-brat Awaiting requested review from dijanin-brat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bmzig @nicholaspai @dijanin-brat @pxrl