feat: Add more functionalities to SpokePoolManager #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
reviewed
Oct 15, 2025
| */ | ||
| getSpokePoolAddresses(): (Address | undefined)[] { | ||
| return Object.values(this.spokePoolClients).map((client) => client.spokePoolAddress); | ||
| } |
There was a problem hiding this comment.
I'm not sure how useful this is as an array because the address alone isn't very useful without the corresponding chainId. Might make sense to just return an Object mapping chainId to Address.
pxrl
reviewed
Oct 15, 2025
| * @note This method returns all SpokePoolClient chainIds. | ||
| */ | ||
| getChainIds(): number[] { | ||
| return Object.keys(this.spokePoolClients).map(Number); |
There was a problem hiding this comment.
For this I prefer using the chainId member of the SpokePoolClient instance itself.
Suggested change
| return Object.keys(this.spokePoolClients).map(Number); | |
| return Object.values(this.spokePoolClients).map({ chainId } => chainId); |
There was a problem hiding this comment.
I am okey with that, but is there case where that can be different?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.