improve(Address): Support new Address from nontraditional encoding #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVM events emit addresses with base58-encoding. At least two addresses emitted within an FundsDeposited or FilledRelay event will need to be converted to a base16 EVM address. Make it easy by permitting the caller of EvmAddress.from() to specify the encoding, defaulting to base16.
pxrl
commented
Apr 8, 2025
pxrl
changed the title
pxrl
commented
Apr 9, 2025
| @@ -223,8 +223,20 @@ export class EvmAddress extends Address { | |||
| } | |||
|
|
|||
| // Constructs a new EvmAddress type. | |||
| static from(hexString: string): EvmAddress { | |||
| return new this(utils.arrayify(hexString)); | |||
| static from(address: string, encoding: "base16" | "base58" = "base16"): EvmAddress { | |||
There was a problem hiding this comment.
nb. We have the option of inferring the encoding with a regex. That'd definitely be a UX improvement...not sure if we want to go there though.
melisaguevara
approved these changes
Apr 15, 2025
james-a-morris
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVM events emit addresses with base58-encoding. At least two addresses emitted within an FundsDeposited or FilledRelay event will need to be converted to a base16 EVM address. Make it easy by permitting the caller of EvmAddress.from() to specify the encoding, defaulting to base16. Also do the same for the SVM side (i.e. permit base16-encoded 32-byte addresses).