-
Notifications
You must be signed in to change notification settings - Fork 75
Add test for validating aria properties for accessibility_requirements
#2329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zlayaAvocado
wants to merge
10
commits into
act-rules:develop
Choose a base branch
from
zlayaAvocado:validate-aria-properties
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add test for validating aria properties for accessibility_requirements
#2329
zlayaAvocado
wants to merge
10
commits into
act-rules:develop
from
zlayaAvocado:validate-aria-properties
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zlayaAvocado
commented
May 12, 2025
accessibility_requirements
WilcoFiers
previously requested changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for validating aria12 properties under
accessibility_requirements
. Since we expect a particularaccessibility_requirements
structure for the rules, thefrontmatter
tests act similar to typescript but for the frontmatter structure.References this issue: #2328
The test job was failing before the fix: https://github.com/act-rules/act-rules.github.io/actions/runs/14984632459/job/42096095113
Need for Call for Review:
This will not require a Call for Review: adds a test
How to Review And Approve