be more safer when trying to freeze objects

actionhero · Oct 16, 2015 · 001218e · 001218e
1 parent f3c516a
commit 001218e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/worker.js b/lib/worker.js
@@ -192,7 +192,11 @@ worker.prototype.perform = function(job, callback) {
             // To help with this, we can stry to make the inputs to the job immutible
             // https://github.com/taskrabbit/node-resque/issues/99
             // Note: if an input is a string or a number, you CANNOT freeze it saddly.
-            for(var i in combinedInputs){ Object.freeze(combinedInputs[i]); }
+            for(var i in combinedInputs){ 
+              if(typeof combinedInputs[i] === 'object'){
+                Object.freeze(combinedInputs[i]); 
+              }
+            }
 
             cb.apply(self, combinedInputs);
           }

diff --git a/test/core/worker.js b/test/core/worker.js
@@ -130,7 +130,7 @@ describe('worker', function(){
     describe('integration', function(){
 
       beforeEach(function(done){
-        worker = new specHelper.NR.worker({connection: specHelper.connectionDetails, timeout: specHelper.timeout, queues: specHelper.queue}, jobs)
+        worker = new specHelper.NR.worker({connection: specHelper.connectionDetails, timeout: specHelper.timeout, queues: specHelper.queue}, jobs);
         worker.connect(done);
       });