Skip to content

Remove Domains

Compare
Choose a tag to compare
@evantahler evantahler released this 05 Oct 16:58
· 1023 commits to main since this release

From the new README:

It is very important that your jobs handle uncaughtRejections and other errors of this type properly. As of node-resque version 4, we no longer use domains to catch what would otherwise be crash-inducing errors in your jobs. This means that a job which causes your application to crash WILL BE LOST FOREVER. Please use catch() on your promises, handle all of your callbacks, and otherwise write robust node.js applications.

If you choose to use domains, process.onExit, or any other method of "catching" a process crash, you can still move the job node-resque was working on to the redis error queue with worker.fail(error, callback).


This is a breaking change which will trigger the v4 release

Solves #166. Visit this issue for a discussion of the possible alternative solutions