Parse env file discard utf8 bom #38

ChristopherHX · 2025-01-29T14:23:28Z

This pr also targeting nektos/act, but probably not a merge candidate in near future

* powershell 5 may add the BOM even when explicitly using utf8

codecov · 2025-01-29T14:54:08Z

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/container/parse_env_file.go	57.14%	2 Missing and 1 partial ⚠️
pkg/runner/run_context.go	57.14%	2 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
pkg/container/parse_env_file.go	`63.26% <57.14%> (ø)`
pkg/runner/run_context.go	`80.08% <57.14%> (ø)`

ChristopherHX · 2025-01-29T16:16:23Z

TLDR waiting for confirmation of gitea user....

ChristopherHX added 4 commits January 29, 2025 15:22

parse_env_file discard utf8 bom

959d8a0

* powershell 5 may add the BOM even when explicitly using utf8

add test + apply to GITHUB_PATH as well

3de0c64

fix it

e163eed

fix powershel 5 syntax

6d75c84

ChristopherHX added 2 commits January 29, 2025 16:40

misc

057011f

fixup

fcc80dd

ChristopherHX marked this pull request as draft January 29, 2025 16:16

ChristopherHX added 2 commits January 29, 2025 18:45

Merge branch 'main' into parse_env_file-discard-utf8-bom

d901a66

fix wrong subaction

9c8b540

ChristopherHX marked this pull request as ready for review February 12, 2025 20:26

ChristopherHX merged commit 27511e3 into main Feb 12, 2025
7 checks passed

ChristopherHX deleted the parse_env_file-discard-utf8-bom branch February 12, 2025 20:26