Skip to content

markdown to WYSIWYG editor and vice versa #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

UnknownSean8
Copy link
Collaborator

Contributor checklist


Description

This PR implements the markdown to WYSIWYG editor and vice versa, there is still some improvements to be made.

Related issue

@andrewtavis andrewtavis self-requested a review April 27, 2025 18:05
Copy link

netlify bot commented Apr 27, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 8ac905b
🔍 Latest deploy log https://app.netlify.com/projects/activist-org/deploys/6828d601e566a70008cb1ad8
😎 Deploy Preview https://deploy-preview-1235--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Via the discussion that we've had on our call, @UnknownSean8, what's needed here is:

  • The height of the write mode for the markdown editor should be conditionally set based on the number of lines of the content when a user switches from preview mode back to write mode
  • We need a checkbox under the text entry for switching on Markdown support rather than the This editor supports Markdown message
    • The text should instead be Enable Markdown support
    • Let's keep the markdown icon so that the option is easier for developers to recognize

Quick note as well that we should do an update of the i18n key for this and also delete all localizations as the text will need to change on Weblate. i18n.components.card_discussion_input.markdown_support should instead be i18n.components.card_discussion_input.enable_markdown. I can do this! 😊

Thanks for the amazing work here! 🚀

@UnknownSean8
Copy link
Collaborator Author

Hi, there are roadblocks here, might need some time to fix.

  1. Height of the texteditor is not resonsive when the button is pressed.
  2. Buttons for the WYSIWYG is not working.

@andrewtavis
Copy link
Member

All good, @UnknownSean8! Let me know if another call would help! 😊

@andrewtavis
Copy link
Member

The above fixes the merge conflicts, @UnknownSean8 :) Let me know if another call to finalize this would help! 😊

@andrewtavis
Copy link
Member

Heyo @UnknownSean8 👋 Quick checkin to see what you're thinking in terms of timing here :) No stress as it's not too pressing, but also nice to bring it in. Happy to hop on a call to pair code the last of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants