Add flate2/libc feature for flate2-zlib #1037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a change in flate2 1.0.10, when "default-features" is false, it is now required to specfy "libc" when specifying the "miniz-sys" feature, in order to compile correctly. Signed-off-by: Peter Schwarz <[email protected]>
|
cc #1036 |
|
@peterschwarz could you update changes.md as well |
|
@fafhrd91 Does that go under the 0.2.9 section? |
|
0.2.9 is released already |
|
Ok, little help then (this is my first PR on this repo): what's the format for that file for new changes? |
Signed-off-by: Peter Schwarz <[email protected]>
|
Nevermind, found an example. |
|
Looks like this error will be taken care of upstream: rust-lang/flate2-rs#206. Perhaps this should be closed, then. |
|
The building issue has been fixed in |
|
Very good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in flate2 1.0.10, when "default-features" is false, it is now required to specfy "libc" when specifying the "miniz-sys" feature, in order to compile correctly.
See the comments in rust-lang/flate2-rs#205