Skip to content

ref: ACTS compliant renaming #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niermann999 wants to merge 2 commits into
base: main
Choose a base branch
from

Rename surface barcode to identifier

0af958b
Select commit
Loading
Failed to load commit list.
Open

ref: ACTS compliant renaming #1131

Rename surface barcode to identifier
0af958b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 8, 2026 in 5m 28s

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 100 in core/include/detray/geometry/identifier.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer "std::to_underlying" to "std::underlying_type_t" to cast enums to their underlying type. 

See more on https://sonarcloud.io/project/issues?id=acts-project_detray&issues=AZ0_DjeqG4UEpUEQW6UV&open=AZ0_DjeqG4UEpUEQW6UV&pullRequest=1131

Check warning on line 176 in core/include/detray/geometry/identifier.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an intermediary "std::to_underlying" to cast an enum to an integral type that is not the underlying type. 

See more on https://sonarcloud.io/project/issues?id=acts-project_detray&issues=AZ0_DjeqG4UEpUEQW6UW&open=AZ0_DjeqG4UEpUEQW6UW&pullRequest=1131
View more details on SonarQubeCloud