fix: presets and add new dev preset#1136
fix: presets and add new dev preset#1136niermann999 wants to merge 2 commits intoacts-project:mainfrom
Conversation
|
Picks up changes in #1134 |
niermann999
force-pushed
the
fix-prests
branch
2 times, most recently
from
37ca957 to
15605a1
Compare
krasznaa
left a comment
krasznaa
left a comment
There was a problem hiding this comment.
I should be able to make something like this work for myself. With some additional tweaks on top, but that's what CMakeUserPresets.json is for after all...
| "name": "dev-fp64", | ||
| "displayName": "FP64 Developer Configuration: Build all Dependencies", | ||
| "displayName": "FP64 Developer Configuration: Build main Components", | ||
| "inherits": [ "dev-fp32" ], |
There was a problem hiding this comment.
It sort of throws the natural-looking dependency stricture out of the window, but I think it's better to make the fp64 versions inherit from the fp32 versions. And then just override "DETRAY_CUSTOM_SCALARTYPE" in them.
This way the "complicated" part of the configuration only has to be written once.
Again, I agree that this is a bit counter-intuitive. But I think that's the best way of organizing this code.
niermann999
force-pushed
the
fix-prests
branch
3 times, most recently
from
bdc0960 to
7669cd1
Compare
|
2 participants
Fixes the prefetch of the Eigen source and adds a new dev preset that as the base of the accelerator presets.