Fix incorrect assertion in build_tracks kernel#1251
Open
stephenswat wants to merge 1 commit intoacts-project:mainfrom
Open
Fix incorrect assertion in build_tracks kernel#1251stephenswat wants to merge 1 commit intoacts-project:mainfrom
build_tracks kernel#1251stephenswat wants to merge 1 commit intoacts-project:mainfrom
Conversation
This commit fixes an incorrect assertion in the `build_tracks` kernel to account for the fact that this kernel can now produce fitted tracks. It also re-enables the check for duplicate measurements on each track.
|
krasznaa
reviewed
Feb 9, 2026
Comment on lines
+230
to
+231
| assert(measurements.at(i.index).identifier() != | ||
| measurements.at(j.index).identifier()); |
Member
There was a problem hiding this comment.
But if we use MBF, this could potentially lead to invalid memory access, no? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an incorrect assertion in the
build_trackskernel to account for the fact that this kernel can now produce fitted tracks. It also re-enables the check for duplicate measurements on each track.