Add GBTS command-line options and config reading#1288
Open
stephenswat wants to merge 1 commit intoacts-project:mainfrom
Open
Add GBTS command-line options and config reading#1288stephenswat wants to merge 1 commit intoacts-project:mainfrom
stephenswat wants to merge 1 commit intoacts-project:mainfrom
Conversation
stephenswat
added
feature
stephenswat
force-pushed
the
feat/gbts_config_reading
branch
from
b05c833 to
279618e
Compare
stephenswat
force-pushed
the
feat/gbts_config_reading
branch
from
279618e to
06674bd
Compare
|
krasznaa
reviewed
Apr 8, 2026
Member
krasznaa
left a comment
krasznaa
left a comment
There was a problem hiding this comment.
We will need to have a discussion at one point about how we would handle configuration (files) in the future. This PR can go ahead without that, but I'll be really interested how this is imagined to work in a production system later on. 🤔
Comment on lines
+30
to
+33
| // config info from file | ||
| std::vector<std::pair<uint64_t, short>> barcodeBinning; | ||
| std::vector<std::pair<int, std::vector<int>>> binTables; | ||
| traccc::device::gbts_layerInfo layerInfo; |
Member
There was a problem hiding this comment.
Would it not be better to just have a
Suggested change
| // config info from file | |
| std::vector<std::pair<uint64_t, short>> barcodeBinning; | |
| std::vector<std::pair<int, std::vector<int>>> binTables; | |
| traccc::device::gbts_layerInfo layerInfo; | |
| /// Configuration object | |
| gbts_seedfinder_config config; |
object in there? Then we could easily add more command line options later on, as needed. In case we'd want to override even more options from the command line. 🤔
Though I don't claim to properly understand the code organization at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit lifts the non-controversial parts out of #1194 so that we can unblock the developments of Fabrice, Mikkel, and Mark.