Skip to content

Conversation

@matt-fidd
Copy link
Member

@matt-fidd matt-fidd commented Feb 20, 2025

All worked smoothly here apart from adm-zip which breaks after 0.5.12 (only 4 patches behind latest though) because process.versions is set to {} instead of unset in the browser. I think it's caused by webpack but it's not the intended behaviour (adm-zip tries to guard against this for browser environments), I've opened cthackers/adm-zip#551 upstream to fix.

This is prep for bumping more deps, but with the next ones being minor/major changes with potential breaking changes they'll be separated into more PRs.

Tested fairly thoroughly, I think if it gets through CI there should be minimal risk here.

@actual-github-bot actual-github-bot bot changed the title bump deps to most recent patch versions [WIP] bump deps to most recent patch versions Feb 20, 2025
@netlify
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6a46d92
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67b697bdf784e20008565e65
😎 Deploy Preview https://deploy-preview-4412.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
17 6.94 MB → 6.95 MB (+4.5 kB) +0.06%
Changeset
File Δ Size
node_modules/@react-spring/rafz/dist/react-spring_rafz.modern.mjs 🆕 +3.57 kB 0 B → 3.57 kB
node_modules/usehooks-ts/dist/index.js 📈 +528 B (+8.24%) 6.26 kB → 6.77 kB
node_modules/ua-parser-js/src/main/ua-parser.mjs 📈 +3.39 kB (+5.30%) 64.02 kB → 67.41 kB
node_modules/react-hotkeys-hook/dist/react-hotkeys-hook.esm.js 📈 +682 B (+3.90%) 17.06 kB → 17.73 kB
node_modules/@emotion/serialize/dist/emotion-serialize.esm.js 📈 +118 B (+1.91%) 6.05 kB → 6.16 kB
node_modules/@react-spring/web/dist/react-spring_web.modern.mjs 📈 +111 B (+1.40%) 7.73 kB → 7.84 kB
node_modules/re-resizable/lib/index.js 📈 +369 B (+1.12%) 32.16 kB → 32.52 kB
node_modules/@emotion/utils/dist/emotion-utils.browser.esm.js 📈 +15 B (+0.89%) 1.64 kB → 1.66 kB
package.json 📈 +3 B (+0.10%) 2.99 kB → 2.99 kB
node_modules/react-error-boundary/dist/react-error-boundary.esm.js 📉 -36 B (-0.86%) 4.08 kB → 4.04 kB
node_modules/react-virtualized-auto-sizer/dist/react-virtualized-auto-sizer.esm.js 📉 -185 B (-1.20%) 15.03 kB → 14.85 kB
node_modules/@emotion/cache/dist/emotion-cache.browser.esm.js 📉 -402 B (-2.95%) 13.31 kB → 12.91 kB
src/hooks/useLocalPref.ts 📉 -9 B (-4.33%) 208 B → 199 B
node_modules/@react-spring/shared/dist/react-spring_shared.modern.mjs 📉 -3.63 kB (-13.09%) 27.71 kB → 24.08 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 4.31 MB → 4.32 MB (+4.5 kB) +0.10%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/en-GB.js 99.42 kB 0%
static/js/de.js 111.72 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/workbox-window.prod.es5.js 5.69 kB 0%
static/js/en.js 100.65 kB 0%
static/js/pt-BR.js 106.43 kB 0%
static/js/uk.js 111.11 kB 0%
static/js/nl.js 98.54 kB 0%
static/js/fr.js 72.19 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 85.76 kB 0%
static/js/useAccountPreviewTransactions.js 1.69 kB 0%
static/js/AppliedFilters.js 10.52 kB 0%
static/js/wide.js 102.9 kB 0%
static/js/ReportRouter.js 1.59 MB 0%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.33 MB → 1.14 MB (-195.93 kB) -14.37%
Changeset
File Δ Size
node_modules/which-boxed-primitive/node_modules/is-symbol/index.js 🆕 +767 B 0 B → 767 B
node_modules/which-boxed-primitive/node_modules/is-bigint/index.js 🆕 +737 B 0 B → 737 B
node_modules/adm-zip/methods/zipcrypto.js 📈 +313 B (+5.74%) 5.33 kB → 5.63 kB
node_modules/adm-zip/headers/entryHeader.js 📈 +80 B (+0.70%) 11.09 kB → 11.17 kB
node_modules/adm-zip/adm-zip.js 📈 +69 B (+0.22%) 30.34 kB → 30.41 kB
node_modules/adm-zip/zipFile.js 📈 +25 B (+0.18%) 13.33 kB → 13.35 kB
packages/crdt/src/crdt/timestamp.ts 📉 -411 B (-2.36%) 17 kB → 16.6 kB
node_modules/google-protobuf/google-protobuf.js 📉 -181.73 kB (-73.35%) 247.78 kB → 66.04 kB
node_modules/is-symbol/index.js 🔥 -767 B (-100%) 767 B → 0 B
node_modules/is-bigint/index.js 🔥 -737 B (-100%) 737 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.33 MB → 1.14 MB (-195.93 kB) -14.37%

Unchanged

No assets were unchanged

@matt-fidd matt-fidd closed this Feb 20, 2025
@matt-fidd matt-fidd deleted the bump-patch branch February 27, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant