-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Feat/add-budget-analysis-report #6137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/add-budget-analysis-report #6137
Conversation
✅ Deploy Preview for actualbudget-website canceled.
|
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Co-authored-by: tabedzki <[email protected]>
…ay controls Co-authored-by: tabedzki <[email protected]>
…readsheet.ts Co-authored-by: tabedzki <[email protected]>
…ace interval button with dropdown Co-authored-by: tabedzki <[email protected]>
Co-authored-by: tabedzki <[email protected]>
348962c to
7e69c1a
Compare
|
It looks like the functional tests fail due to an artifact naming conflict. I believe this will require action from a maintainer. |
|
For the maintainers, the new Budget Analysis Report is available on the test budget. (I am also comfortable with a name change if the maintainers prefer a different name.) |
Auto-generated by VRT workflow PR: actualbudget#6137
|
✅ VRT screenshots have been automatically updated. |
Auto-generated by VRT workflow PR: actualbudget#6137
|
✅ VRT screenshots have been automatically updated. |
|
Sorry about the delay. I'll try and rectify the issue soon |
|
@youngcw I found the differences between the balance values: this report assumes rollover between months. I personally believe overspending should automatically roll over though I understand that might not be the design philosophy for Actual. What's your suggestion for how that should behave? |
|
I would expect the report to match the budget table. Anything else seems incorrect to me since this is claiming to report on the budget. |
|
Is the summary in the corner always just the numbers from the last month of the plot? I would expect the budgeted and spent numbers to be the total over the period. The balance one can probably stay as the ending balance, but maybe the text should say "Ending balance" |
|
I can do modify it to reflect the numbers over the period. I'm uncomfortable/hesitant about the inherent discrepancy that occurs between "balanced" and "budgeted - spent" due to the possibility of not carrying over "overspending". If there's overspending that is not carried over, then the ending balance over the period will not reflect the "budgeted - spent" over the period. Is that sort of numerical discrepancy acceptable in this case? Should we have this be explicitly noted (and possibly linked to the documentation) so that users are aware of this possibility? I've moved this back to drafts since I need to write up some docs and generate figures. |
|
Could there be a line for overspending adjustments? That may be useful to know in the report and then the math could all add up |
|
Adding in the overspending line @youngcw is there a way to only show certain filters? Currently, I import the header and those filters include irrelevant options such as "Accounts" given that this is focused only on the budget. |
Not that I know of |
|
Okay thanks. That'd be something nice to have for certain reports but I understand if it isn't doable in the short term. I can write in the comments that only I also have a problem for currencies in my graph where the Y axis currency gets cut off. Do you know if that's a general formatting issue that would be addressed outside of the report framework, or is this something that I need to fix on my end (formatting, etc)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Youngcw, I believe it's ready at this time for a review.
edit: Image for docs added and fixed support for conditionsOp
…t-analysis-spreadsheet components
|
I don't know if I like that the hover tooltip has a different order of values than the summary does. What do you think about making that order the same? So move the balance value in the tooltip to the bottom. I like the overspend adjustment number. Im not sure about it being in the month being fixed, vs being in the month after like the budget does. Could that be in the next month like its handled on budget? What do you think? |
|
Also, take a look at the recently merged reports pages PR. It added a copy function to each report and that will need added here. |





Feature: add budget analysis report
This feature allows the user to track how the Budget/Spent/Balance of categories as a function of time.
This feature is modelled after the Cash Flow and Net Worth reports. Currently, the user defines the interval resolution unlike "Cash Flow" which has the interval resolution (daily/monthly, etc) defined for each preset option. This can be adjusted based off maintainer feedback.
This feature also allows for both a line chart and bar chart representation, with balance always being a line chart.
Thank you maintainers for looking at this and considering this. This is related to feature request #6116
AI disclaimer: this PR was partly generated with Copilot as indicated in the git history.
Image of cards on report dashboard:
Individual pages:

