Matiss/category merges #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented getCategoryMappings to retrieve mappings of old category IDs to merged category IDs, handling cases where the database is not initialized or the category_mapping table does not exist. - Updated getTransactions and getBudgetedAmounts functions to resolve category IDs through the merge chain, ensuring accurate category representation in transactions and budget calculations. - Added unit tests for getCategoryMappings to verify its behavior under various scenarios, including database initialization and table existence. - Enhanced data transformation tests to ensure transactions are correctly categorized under merged categories.
✅ Deploy Preview for actual-wrapped ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Removed category mapping resolution for budget calculations, simplifying the logic by directly using category IDs. - Updated comments for clarity on budget accumulation by category and month. - Enhanced performance by eliminating unnecessary mapping operations related to merged categories.
…ove category handling - Updated the BudgetVsActualPage component to filter out deleted categories and groups, ensuring they are not displayed in the UI. - Enhanced the logic for grouping and sorting categories, maintaining only active categories and special cases. - Modified related tests to verify the correct filtering behavior and ensure that deleted categories do not appear in the selection options. - Improved data transformation logic to prevent the inclusion of non-existent categories in budget calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.