Skip to content

Conversation

lisbravo
Copy link

@lisbravo lisbravo commented Aug 9, 2022

The UC8151D driver was not working properly with the 2,13 inch flex Epaper Display, connected to a eInk Breakout Friend. Tested on a few different boards.
The cause of this was that the driver needs to send the resolution of the display to the driver IC, which is what this commit fixes.

Haven't tested partial initialization though, when I get to the point of needing that, if there is any further work to do, I'll submit another commit.

As always, thanks for such a great job 😄

@lisbravo lisbravo force-pushed the fix_UC8151D_resolution branch from 5d9b802 to 08a591e Compare August 11, 2022 12:49
@ladyada
Copy link
Member

ladyada commented Aug 12, 2022

can we do it without two new variables? we already have width and height as class variables?

@lisbravo
Copy link
Author

lisbravo commented Aug 13, 2022

can we do it without two new variables? we already have width and height as class variables?

Please correct me if Im wrong, but width and height are parameters of the constructor and not actual class members, and as such they cannot (or should not) be accessed by other class functions.
But maybe Im missing something ...

@mirzafahad
Copy link

@lisbravo You can call width() and height() to get the width and height that were specified when the Adafruit_UC8151D instance was created. Width and height propagate to Adafruit_EPD' and then to Adafruit_Gfx`.

UC8151D now sets the display resolution

TBS
@lisbravo lisbravo force-pushed the fix_UC8151D_resolution branch from 08a591e to 478fd24 Compare August 23, 2022 17:18
@lisbravo
Copy link
Author

@mirzafahad Thanks man
@ladyada pls have a look, unfortunately I don't have the HW available anymore but this is a minor change from my initial, HW verified, pull request

@ladyada
Copy link
Member

ladyada commented Aug 23, 2022

thanks, we'll test this on hardware!

@ladyada ladyada requested a review from makermelissa August 23, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants