Allow Selection of _bleio by Board, Fixup CIRCUITPY_BLEIO Flags#9878
Allow Selection of _bleio by Board, Fixup CIRCUITPY_BLEIO Flags#9878dhalbert merged 5 commits intoadafruit:mainfrom
Conversation
|
Marked as work in progress. Using CI to verify correct builds for all ports/boards. |
|
@eightycc I was going to do this and then saw you already did! It just needs a merge conflict fixed. I would also like to get the Module Support Matrix to include an annotation that describes which "_bleio (native)": "CIRCUITPY_BLEIO_NATIVE",
"_bleio (HCI co-processor)": "CIRCUITPY_BLEIO_HCI",I also had another thought, which I'm not sure is a good idea at all, but is an idea. Asking @tannewt also: EDIT: as described in #10218, I don't think is such a great idea: Suppose try:
import _bleio
except ImportError
import _bleio_hci as _bleioConceivably, one could make a build that would support both, though it's not of much use (though there are compile issues about that, so you don't have to duplicate the shared-bindings code). |
|
Like Barliman Butterbur in LOTR, I completely forgot about this one. One thing drives out another! I'll pick it up again, if you'd like. |
|
@dhalbert I'm splitting this. This PR covers the original change plus the recommended support matrix update. I'll open a separate issue for |
|
@dhalbert Pinging for a review. |
dhalbert
left a comment
There was a problem hiding this comment.
OK, this looks good, going on my recollections of the previous PR. Thanks!
|
The disambiguated |
@dhalbert I see the extra |

Allows selection of
_bleioimpementation by board within a port. Makes explicit HCI device inclusion by replacing use of vpath.Changes meanings of
CIRCUITPY_BLEIO*flags as follows:CIRCUITPY_BLEIO: Any_bleioimplementation is part of this build. Automatically set.CIRCUITPY_BLEIO_NATIVE: Selects the port's native_bleioimplementation.CIRCUITPY_BLEIO_HCI: Selects the serial HCI implementation.