Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frozen libraries version numbers #9959

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented Jan 14, 2025

When we switched to the PEP 440 compatible version number "0.0.0+auto.0" instead of "0.0.0-auto.0" we didn't update the preprocess script for frozen modules, so they have been having a wrong version number ever since. Sorry :D
This PR fixes that.

before

Adafruit CircuitPython 9.2.2 on 2025-01-09; Adafruit PyPortal with samd51j20
>>> import adafruit_fakerequests
>>> adafruit_fakerequests.__version__
'0.0.0+auto.0'

after

Adafruit CircuitPython 9.2.2-6-g9004f20af0-dirty on 2025-01-14; Adafruit PyPortal with samd51j20
>>> import adafruit_fakerequests
>>> adafruit_fakerequests.__version__
'1.0.14'

Note that some community modules still use the other format, so I kept it.

❯ ag 0.0.0-
circuitpython_ef_music/elecfreaks_music.py
17:__version__ = "0.0.0-auto.0"

Adafruit_CircuitPython_ImageLoad/adafruit_imageload/png.py
28:__version__ = "0.0.0-auto.0"

mixgo_cp_lib/mixgoce_lib/matrix.py
33:__version__ = "0.0.0-auto.0"

mixgo_cp_lib/mixgoce_lib/adafruit_minimqtt.py
35:__version__ = "0.0.0-auto.0"

mixgo_cp_lib/mixgoce_lib/adafruit_framebuf.py
45:__version__ = "0.0.0-auto.0"

mixgo_cp_lib/mixgoce_lib/adafruit_irremote.py
77:__version__ = "0.0.0-auto.0"

(The adafruit_imageload one is one of the submodules, it does not really impact anything).

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert dhalbert merged commit db4f059 into adafruit:main Jan 14, 2025
587 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants