Skip to content

Adhere to zizmor audit#15

Merged
adam-fowler merged 7 commits intoadam-fowler:mainfrom
hakonk:claude/zizmor-autofix-uXcRL
Feb 20, 2026
Merged

Adhere to zizmor audit#15
adam-fowler merged 7 commits intoadam-fowler:mainfrom
hakonk:claude/zizmor-autofix-uXcRL

Conversation

@hakonk
Copy link
Contributor

@hakonk hakonk commented Feb 18, 2026

Make workflows follow best practices as suggested by zizmor.

- Pin actions/checkout to commit SHA (34e114876b0b11c390a56381ad16ebd13914f8d5 = v4.3.1) to prevent unpinned-uses issues
- Add persist-credentials: false to all checkout steps to prevent credential persistence via artifacts (artipacked)
- Add permissions: contents: read at workflow level to enforce least-privilege (excessive-permissions)
- Pin swift:latest container image to digest SHA in api-breakage.yml (unpinned-images)

https://claude.ai/code/session_01M2EYC8u9r213nUxBvk9f6h
Copy link
Owner

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge most of these

timeout-minutes: 15
container:
image: swift:latest
image: swift:6.2.3@sha256:6dd90eb2359663a2cde8f03e9951f488b23134b3b8fce20e9dcb6cada75dd803
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just stick to swift:latest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given you are updating this file can you update the list of images to swift:6.0, swift:6.1, swift:6.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-fowler adam-fowler merged commit 9392d9d into adam-fowler:main Feb 20, 2026
5 checks passed
@hakonk hakonk deleted the claude/zizmor-autofix-uXcRL branch February 25, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants