Optimized compare_ref function from loop logic to dataframe logic#226
Open
TrangNg-Th wants to merge 1 commit into
Open
Optimized compare_ref function from loop logic to dataframe logic#226TrangNg-Th wants to merge 1 commit into
TrangNg-Th wants to merge 1 commit into
Conversation
… improved performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request optimizes the
compare_reffunction for faster run of bam merging step after creating mutated bam file. In this version, Ipandaspackage to handle and compare references faster.bamsurgeon.defSingularity definition file, allowing users to build a Singularity image for executing the code.singularity build bamsurgeon.sif bamsurgeon.defAdditional Dependencies
pandasBenefits
Benchmark
Test Setup:
Performance Improvement:
addsnv.pyscript execution time has been reduced from approximately 4 hours to 2-3 minutes with the optimizedcompare_reffunction.