Two bugfixes, including adbuerger/pycombina#27#33
Open
mirhahn wants to merge 1 commit intoadbuerger:developfrom
Open
Two bugfixes, including adbuerger/pycombina#27#33mirhahn wants to merge 1 commit intoadbuerger:developfrom
mirhahn wants to merge 1 commit intoadbuerger:developfrom
Conversation
The unnamed bug occurs only when the extension module is compiled with debugging flags. In this case, the final stat output would use Python's print function without acquiring the Global Interpreter Lock, which would trigger an error in Python (or potentially crash if Python is compiled without debugging flags). Note: The issue-specific test has been removed to avoid licensing issues.
mirhahn
force-pushed
the
issues/upstream#27
branch
from
733496f to
dea31d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request appears to fix the
max_up_timeissue #27. It modifiesCombinaBnBSolver::compute_child_node_propertiesso thatup_time_child[b_active_parent]is reset to0.0when the control switches and the parent control exists (i.e., the node is not root).I had to reverse-engineer and guess what the semantics of some of the variables are. The result appears to pass all tests, but since this is a very central method, this should be scrutinized more heavily. I have also added some comments with my best guesses as to what the code does. Maybe some of these can be retained.
During debugging, I have also noticed some debugging output that does not lock the GIL, thereby crashing the solver if compiled with debugging symbols. I have also fixed that.
Note: The additional test case has been squashed out of the branch. I am unsure as to whether it would cause licensing issues because it is derived from @jelgerjansen's reproduction instructions. The new version does not include anything other than my own code patches.