Skip to content

Modified XPath to also search for Activity Alias #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesikanos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modified XPath to also search for Activity Alias #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ function parseManifest(xml) {
result.activities = activity_nodes.map(n => attributeValue(n));
}

// extract the default launcher activity
const launcher_xpath = '/manifest/application/activity[intent-filter/action[@android:name="android.intent.action.MAIN"] and intent-filter/category[@android:name="android.intent.category.LAUNCHER"]]/@android:name';
// extract the default launcher activity (Looking for <activity> or <activity-alias> with intent-filter action=MAIN and category=LAUNCHER)
const launcher_xpath = '(/manifest/application/activity[intent-filter/action[@android:name="android.intent.action.MAIN"] and intent-filter/category[@android:name="android.intent.category.LAUNCHER"] and not(@android:enabled="false")] | /manifest/application/activity-alias[intent-filter/action[@android:name="android.intent.action.MAIN"] and intent-filter/category[@android:name="android.intent.category.LAUNCHER"] and not(@android:enabled="false")])/@android:name';
const launcher_nodes = android_select(launcher_xpath, doc);
// should we warn if there's more than one?
if (Array.isArray(launcher_nodes) && launcher_nodes.length >= 1) {
Expand Down