Open
Conversation
|
Any update on this? |
Author
Waiting on Belha's review. @zegeek, please let me know if there's anything I can do to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively small change which ensures we handle libpq errors whilst
COPYing data and abort in case any error occurs. This partially fixes #80 which is a partial aid against data loss where we lose at most one batch of data in case of errors on postgresql side. The batch size is hardcoded to 2000 at the moment. The second part of the issue where we ensure to retain messages in case of a libpq error is left to be fixed in a future PR.